Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Исправить часть warning, обновить некоторые методы из #1222 #1600

Merged
merged 20 commits into from
Nov 11, 2023
Merged

Исправить часть warning, обновить некоторые методы из #1222 #1600

merged 20 commits into from
Nov 11, 2023

Conversation

1dNDN
Copy link
Contributor

@1dNDN 1dNDN commented Nov 11, 2023 •
edited
Loading

Список изменений

Исправлены warning

  • Local constant 'expectedUserId' is never
  • Redundant 'Attribute' suffix
  • Dictionary lookup can be simplified with 'TryGetValue'
  • S6608: Indexing at 0 should be used instead of the "Enumerable" extenion method "First"
  • The keyword 'new' is required on 'AccessKey' because it hides property 'string VkNet.Model.MediaAttachment.AccessKey'
  • Using directive is not required by the code and can be safely removed
  • The keyword 'new' is required on 'PhotoId' because it hides property 'long? VkNet.Model.Comment.PhotoId'
  • Conditional access qualifier expression is known to be not null
  • Cannot resolve symbol BotsLongPollUpdatesHandler
  • Code is unreachable

Обновил методы из #1222

  • ads.getAds
  • ads.getAdsLayout
  • apps.get
  • wall.postAdsStealth
  • wall.editAdsStealth
  • video.addToAlbum
  • friends.areFriends
  • friends.getMutual
Обязательно выполните следующие пункты:
  • Проверьте что ваш код не содержит конфликтов, и исправьте их по необходимости
  • Напишите тесты, и обязательно проверьте что не падают другие.
Внимание! Pull Request'ы с непройденными тестами не принимаются

1dNDN added 15 commits November 11, 2023 20:51
@1dNDN
Local constant 'expectedUserId' is never used
d9616e5
@1dNDN
Redundant 'Attribute' suffix
d98026d
@1dNDN
Dictionary lookup can be simplified with 'TryGetValue'
e26de12
@1dNDN
S6608: Indexing at 0 should be used instead of the "Enumerable" exten…
1f381b3 
…sion method "First"

Indexing at Count-1 should be used instead of the "Enumerable" extension method "Last"

https://rules.sonarsource.com/csharp/RSPEC-6608/
@1dNDN
The keyword 'new' is required on 'AccessKey' because it hides propert…
2aa86df 
…y 'string VkNet.Model.MediaAttachment.AccessKey'
@1dNDN
Using directive is not required by the code and can be safely removed
2c0c852
@1dNDN
The keyword 'new' is required on 'PhotoId' because it hides property …
252684b 
…'long? VkNet.Model.Comment.PhotoId'

The keyword 'new' is required on 'PostId' because it hides property 'long? VkNet.Model.Comment.PostId'
@1dNDN
Using directive is not required by the code and can be safely removed
9afab49
@1dNDN
Conditional access qualifier expression is known to be not null
b9f9d5e
@1dNDN
Cannot resolve symbol BotsLongPollUpdatesHandler
f83797f
@1dNDN
Code is unreachable
96fd2db
@1dNDN
Using directive is not required by the code and can be safely removed
0be147e
@1dNDN
add only_deleted param to ads.getAds
4d165e5
@1dNDN
add only_deleted to ads.getAdsLayout
b2296f2
@1dNDN
add app_id to apps.get
3308cb1
@1dNDN 1dNDN changed the title Исправит часть warning, обновить некоторые методы из #1222 Исправить часть warning, обновить некоторые методы из #1222 Nov 11, 2023
@1dNDN 1dNDN marked this pull request as ready for review November 11, 2023 19:44
@inyutin-maxim
Copy link
Member

@1dNDN Пометьте PR как черновик пока не закончите

@inyutin-maxim inyutin-maxim merged commit 7fa349d into vknet:develop Nov 11, 2023
1 check passed
@inyutin-maxim
Copy link
Member

Спасибо за проделанную работу
Добавлено к следующему релизу. Либо можете получить обновление из альфа канала: https://www.myget.org/F/vknet

@inyutin-maxim inyutin-maxim added this to the v1.77.0 milestone Nov 11, 2023
@inyutin-maxim inyutin-maxim linked an issue Nov 11, 2023 that may be closed by this pull request
Some methods have been changed #1222
Open
90 tasks
@inyutin-maxim inyutin-maxim self-requested a review November 11, 2023 19:51
@inyutin-maxim inyutin-maxim added the Pull Request Исправление внесенное пользователем не состоящим в основном списке разработчиков label Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inyutin-maxim inyutin-maxim Awaiting requested review from inyutin-maxim

Assignees

@1dNDN 1dNDN

Labels
Pull Request Исправление внесенное пользователем не состоящим в основном списке разработчиков
Projects
None yet
Milestone
v1.77.0
Development

Successfully merging this pull request may close these issues.

Some methods have been changed
2 participants
@1dNDN @inyutin-maxim