Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'modal' prop from Filter dialogue #25

Open
newswim opened this issue Sep 4, 2017 · 0 comments
Open

Remove 'modal' prop from Filter dialogue #25

newswim opened this issue Sep 4, 2017 · 0 comments

Comments

@newswim
Copy link

newswim commented Sep 4, 2017

This is totally a matter of taste, and I don't mean to imply one way or the other is "more right" or even "right in this context"... but as a user, I expected that clicking outside of the Filter modal would close the modal (which is default behavior for MUI's Dialogue component).

Author's discretion, but removing this line would accomplish this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant