Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent fromClient data keys in RelationalBone #1045

Open
sveneberth opened this issue Jan 26, 2024 · 0 comments
Open

Inconsistent fromClient data keys in RelationalBone #1045

sveneberth opened this issue Jan 26, 2024 · 0 comments
Labels
bug(fix) Something isn't working or address a specific issue or vulnerability Priority: High After critical issues are fixed, these should be dealt with before any further issues.
Milestone
ViUR-core v3.7

Comments

@sveneberth
Copy link
Member

sveneberth commented Jan 26, 2024 •
edited

With a using skel the viur-core expects "{bonename}.key in the formdata, but without a using skel only "{bonename}.

This is inconsistent and causes problems with the current implementation in the vi-admin.

We should support both syntaxes or only one (@phorward and I prefer the variant without the .key and keep the .anything keys for the using skel).

I already tried to create a quick and dirty solution, but unfortunately this is no working with multiple bones yet.
@sveneberth sveneberth added bug(fix) Something isn't working or address a specific issue or vulnerability Priority: High After critical issues are fixed, these should be dealt with before any further issues. labels Jan 26, 2024
@sveneberth sveneberth changed the title Inconsistent fromClient in RelationalBone Inconsistent fromClient data keys in RelationalBone Jan 26, 2024
@sveneberth sveneberth mentioned this issue Feb 20, 2024
Open
@phorward phorward added this to the ViUR-core v3.7 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug(fix) Something isn't working or address a specific issue or vulnerability Priority: High After critical issues are fixed, these should be dealt with before any further issues.
Projects
None yet
Milestone
ViUR-core v3.7
Development

No branches or pull requests
2 participants
@sveneberth @phorward