Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(diff): truncate to avoid crash on diff large objects #7133

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Dec 26, 2024

Description

This isn't fool-proof for all situations, but it seems to help dealing with some cases.

For playwright's case, the large formatting happens because of callToJSON: false, which is used only when comparing against two different "types" of objects (ElementHandle vs null in the repro's case). ElementHandle.toJSON is something compact like this:

Object {
  "_guid": "handle@c697bfba7ffbd40d2511ee19416963a8",
  "_type": "ElementHandle",
}

const FALLBACK_FORMAT_OPTIONS = {
callToJSON: false,
maxDepth: 10,
plugins: PLUGINS,
}

I also noticed prettyFormat actually succeeds, but large memory consumption happens probably later when going through RPC etc... So the fix here is to just truncate beforehand for FALLBACK_FORMAT_OPTIONS case and also reduce the default FALLBACK_FORMAT_OPTIONS.maxDepth a little.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Dec 26, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 714d34e
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/676d028002f4dd0008c368e4
😎 Deploy Preview https://deploy-preview-7133--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Dec 26, 2024

@vitest/browser

npm i https://pkg.pr.new/@vitest/browser@7133

@vitest/coverage-v8

npm i https://pkg.pr.new/@vitest/coverage-v8@7133

@vitest/coverage-istanbul

npm i https://pkg.pr.new/@vitest/coverage-istanbul@7133

@vitest/expect

npm i https://pkg.pr.new/@vitest/expect@7133

@vitest/pretty-format

npm i https://pkg.pr.new/@vitest/pretty-format@7133

@vitest/mocker

npm i https://pkg.pr.new/@vitest/mocker@7133

@vitest/runner

npm i https://pkg.pr.new/@vitest/runner@7133

@vitest/snapshot

npm i https://pkg.pr.new/@vitest/snapshot@7133

@vitest/spy

npm i https://pkg.pr.new/@vitest/spy@7133

@vitest/ui

npm i https://pkg.pr.new/@vitest/ui@7133

@vitest/utils

npm i https://pkg.pr.new/@vitest/utils@7133

vite-node

npm i https://pkg.pr.new/vite-node@7133

@vitest/web-worker

npm i https://pkg.pr.new/@vitest/web-worker@7133

vitest

npm i https://pkg.pr.new/vitest@7133

@vitest/ws-client

npm i https://pkg.pr.new/@vitest/ws-client@7133

commit: 9ebe2fe

@hi-ogawa hi-ogawa marked this pull request as ready for review December 26, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when printing diff of playwright ElementHandle
1 participant