Fix/to equal undefined comparison #7111
Closed
+147
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
hi-ogawa
requested changes
Dec 22, 2024
hi-ogawa
requested changes
Dec 26, 2024
hi-ogawa
reviewed
Dec 26, 2024
Comment on lines
+717
to
+721
| { | ||
| - "x": "bar", | ||
| - "y": undefined, | ||
| + "x": "foo", | ||
| }", |
There was a problem hiding this comment.
I think the desired diff for toEqual is to drop y: undefined since its existance doesn't affect toEqual assertion.
{
- "x": "bar",
+ "x": "foo",
}
There was a problem hiding this comment.
I have added an additional filterUndefined function which should get the job done
|
I will create a new PR for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7083
Description
This PR fixes the toEqual matcher to consistently ignore undefined properties when comparing objects. Previously, undefined properties were inconsistently highlighted in error messages, leading to confusion. The fix ensures predictable behavior and clearer error messages. Unit tests have been added to validate the changes.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.