How to use test filters without triggering "obsolete snapshot"

[jasonkuhrt]

Hey, when running a command like:

vitest run cli/schema --testNamePattern 'json: true.*should see Invalid Token error.*'

The targeted test runs but then all other tests are considered obsolete.

  Snapshots  1 failed
             70 obsolete

The major usability problem here is that while filtering I cannot update the failing snapshot without causing the others to be deleted, but if I don't filter I have many more tests that are slow etc.

Am I missing something?

[hi-ogawa]

Can you provide a repro? I don't think this should happen with a simple toMatchSnapshot() API. Do you happen to use explicit snapshot name like toMatchSnapshot("my-name")?

[jasonkuhrt]

Yeah we are using explicit snapshot names.

The repo is open source so I can share that later today when I start work.

[jasonkuhrt]

Once this PR is merged I will give you a set of simple repro steps. https://github.com/graphql-hive/console/actions/runs/12425451027/job/34692481602.

[hi-ogawa]

I thought this is a limitation since we cannot track what's the snapshot until toMatchSnapshot("my-name"), but I think we can probably apply a same heuristics as how we handle toMatchSnapshot() which uses auto-icremented number.
(EDIT: oh wait, toMatchSnapshot() actually has the same behavior... 😢)

https://stackblitz.com/edit/vitest-dev-vitest-mitcgkkj?file=test%2F__snapshots__%2Fbasic.test.ts.snap

import { expect, test } from 'vitest';

test('x test', () => {
  expect(0).toMatchSnapshot();  // generates `x test 1`
  expect(0).toMatchSnapshot();  // generates `x test 2`  // when first one fails `x test 2` is considered obsolete
});

test('y test', () => {
  expect(0).toMatchSnapshot('foo'); // generates `y test > bar 1`
  expect(0).toMatchSnapshot('bar'); // generates `y test > foo 1`  // when first on fails `y test > foo 1` is considered obsolete
});

[hi-ogawa]

@jasonkuhrt I made an issue #7113. Can you confirm that's the issue you're seeing?

[jasonkuhrt]

@hi-ogawa that looks right to me! Thanks!