Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: rewrite waitForNavigation to waitForEvent('load') #13413

Merged
merged 1 commit into from Jun 3, 2023

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jun 3, 2023

Description

waitForNavigation is deprecated. The document suggests to use waitForURL but that doesn't work for reloads. This PR replaces waitForNavigation with waitForEvent('load')

waitForURL resolves immediately if the page is already showing that URL.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added p1-chore Doesn't change code behavior (priority) test labels Jun 3, 2023
@stackblitz
Copy link

stackblitz bot commented Jun 3, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev merged commit b28c847 into vitejs:main Jun 3, 2023
14 checks passed
@sapphi-red sapphi-red deleted the test/rewrite-wait-for-navigation branch June 4, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority) test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants