Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Why Not Bundle with esbuild?" section under "Why Vite?" - missing production word in the sentence. #16573

Closed
1 of 4 tasks
akhilpanchal opened this issue May 2, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@akhilpanchal
Copy link

akhilpanchal commented May 2, 2024

Documentation is

  • Missing
  • Outdated
  • Confusing
  • Not sure?

Explain in Detail

"Once Rolldown is ready, it could replace both Rollup and esbuild in Vite, improving build performance significantly and removing inconsistencies between development and build."

The above sentence is not precise about the inconsistencies between development and production builds. I believe that the word "production" is missing from this sentence.

More than happy to contribute this minor doc fix, if this improvement reads clearer.

Your Suggestion for Changes

"Once Rolldown is ready, it could replace both Rollup and esbuild in Vite, improving build performance significantly and removing inconsistencies between development and production builds."

Reproduction

https://vitejs.dev/guide/why.html#why-not-bundle-with-esbuild

Steps to reproduce

  1. Goto https://vitejs.dev/guide/why.html#why-not-bundle-with-esbuild
  2. Read the second paragraph in the section.
@akhilpanchal akhilpanchal added the documentation Improvements or additions to documentation label May 2, 2024
@bluwy
Copy link
Member

bluwy commented May 2, 2024

"development and build" is correct. It's specifically about the inconsistency between vite dev and vite build.

@bluwy bluwy closed this as not planned Won't fix, can't repro, duplicate, stale May 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants