Asynchronous writing in defineConfig will cause npm run build to fail.

[zyronon]

Describe the bug

Writing asynchronously in defineConfig will cause npm run build to fail when Github Action executes the job of docker/build-push-action@v5, but local packaging is completely normal.

Reproduction

https://github.com/zyronon/docker-test

Steps to reproduce

Https://github.com/zyronon/docker-test/, which is a new project just created with pnpm create vite, in which only the vite.config.ts file is modified

It is found that this method of writing is normal for local packaging, but it will fail in Github Action and do not report an error.

import {defineConfig} from 'vite'
import Vue from '@vitejs/plugin-vue'
import {getLastCommit} from 'git-last-commit'

export default defineConfig(async () => {
  const latestCommitHash = await new Promise<string>((resolve) => {
    return getLastCommit((err, commit) => (err ? 'unknown' : resolve(commit.shortHash)))
  })
  return {
    plugins: [
      Vue()
    ],
    define: {
      LATEST_COMMIT_HASH: JSON.stringify(
        latestCommitHash + (process.env.NODE_ENV === 'production' ? '' : ' (dev)')
      )
    },
  }
})

However, there is no problem with this writing either locally or in Github Action.

import {defineConfig} from 'vite'
import Vue from '@vitejs/plugin-vue'
import {getLastCommit} from 'git-last-commit'

export default defineConfig(() => {
  return new Promise(resolve => {
    let latestCommitHash = ''
    getLastCommit((err, commit) => {
      if (!err) latestCommitHash = commit.shortHash
      resolve({
        plugins: [
          Vue()
        ],
        define: {
          LATEST_COMMIT_HASH: JSON.stringify(
            latestCommitHash + (process.env.NODE_ENV === 'production' ? '' : ' (dev)')
          )
        },
      })
    })
  })
})

System Info

System:
    OS: Windows 10 10.0.19045
    CPU: (12) x64 AMD Ryzen 5 5600G with Radeon Graphics
    Memory: 16.16 GB / 27.90 GB
  Binaries:
    Node: 18.13.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.19 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 8.19.3 - C:\Program Files\nodejs\npm.CMD
    pnpm: 8.15.4 - C:\Program Files\nodejs\pnpm.CMD
    bun: 1.1.4 - ~\.bun\bin\bun.EXE
  Browsers:
    Edge: Chromium (123.0.2420.97)
    Internet Explorer: 11.0.19041.3636

Used Package Manager

pnpm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[sapphi-red]

You are not calling resolve or reject when !!err is true. Not calling either of them causes Node.js to exit the process without any messages (nodejs/promises-debugging#16).

const latestCommitHash = await new Promise<string>((resolve) => {
  return getLastCommit((err, commit) => (err ? 'unknown' : resolve(commit.shortHash)))
})

Closing as this is not a bug in Vite.

[zyronon]

You are not calling resolve or reject when !!err is true. Not calling either of them causes Node.js to exit the process without any messages (nodejs/promises-debugging#16).

const latestCommitHash = await new Promise<string>((resolve) => {
  return getLastCommit((err, commit) => (err ? 'unknown' : resolve(commit.shortHash)))
})

Closing as this is not a bug in Vite.

But locally, everything is okay, why?

[sapphi-red]

I guess it's because getLastCommit doesn't error on local and errors on GitHub Actions.