Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dynamic-import-vars plugin normalize path issue #16518

Merged
merged 2 commits into from Apr 25, 2024
Merged

fix: dynamic-import-vars plugin normalize path issue #16518

merged 2 commits into from Apr 25, 2024

Conversation

godky
Copy link
Contributor

@godky godky commented Apr 24, 2024

Description

Parameters wrapped with ` may produce unexpected results in path.normalize or path.posix.normalize。
For example:

path.posix.normalize('../../foo')     // '../../foo'
path.posix.normalize('`../../foo`')   // 'foo`'

@stackblitz StackBlitz
Copy link

stackblitz bot commented Apr 24, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@godky godky marked this pull request as draft April 24, 2024 11:08
@godky godky marked this pull request as ready for review April 24, 2024 12:16
@sapphi-red sapphi-red added the p3-minor-bug An edge case that only affects very specific usage (priority) label Apr 25, 2024
@patak-dev
Copy link
Member

Thanks for the fix!

@patak-dev patak-dev merged commit f71ba5b into vitejs:main Apr 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@godky @patak-dev @sapphi-red