feat(config): support .config dir
#16516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for your work @NozomuIkuta ❤️ Deciding to add more optional paths is totally up to vite project maintainers, but this looks good to me only 👍🏼 |
|
Thanks for creating the PR. I've discussed this with the team and is something we don't plan on supporting at the moment. #15911 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resovles #15911
This PR is to demonstrate what
.configdirectory support looks like, so that core team can discuss with working code.@pi0
Would you check if it follows the convention correctly and add further explanation as needed?
By the way, I don't define
/.config/vite.config.js, although it's written in #15911, because it's written in the original proposal that.configsuffix should be avoided.