Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimatch respects folder paths when used for branch exclusion #254

Open
tommoyang opened this issue Oct 19, 2021 · 0 comments
Open

Minimatch respects folder paths when used for branch exclusion #254

tommoyang opened this issue Oct 19, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@tommoyang
Copy link
Collaborator

Buildkite's branch pattern matching (https://buildkite.com/docs/pipelines/branch-configuration#pipeline-level-branch-filtering) doesn't seem to respect folder paths (e.g. task/KATOA-1234/branch-name) while minimatch does. Buildkite's behaviour is also more expected (probably), so it would be good to match it closer
@tommoyang tommoyang added the bug Something isn't working label Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tommoyang