Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay transparency for IE8 #35

Open
aseemk opened this issue Feb 23, 2012 · 2 comments
Open

Overlay transparency for IE8 #35

aseemk opened this issue Feb 23, 2012 · 2 comments

Comments

@aseemk
Copy link

aseemk commented Feb 23, 2012

Hey, just wondering, any reason you used opacity: 1 and background: rgba(0,0,0,.75) in overlay.css instead of a solid black background and 0.75 opacity? Adding filter: alpha(opacity=75) would allow it to then work in IE8 with no seeming downside for modern browsers.

@tj
Copy link
Member

tj commented Feb 23, 2012

no specific reason, I'd be fine with changing that. I'm ok with bits and pieces to support >IE8 and friends, just nothing huge and unwieldy

@aseemk
Copy link
Author

aseemk commented Feb 23, 2012

Great. The change was simple:

#overlay {
   position: fixed;
   top: 0;
   left: 0;
-  opacity: 1;
+  opacity: 0.75;
+  filter: alpha(opacity=75);
   width: 100%;
   height: 100%;
-  background: rgba(0,0,0,.75);
+  background: black;
   transition: opacity 300ms;
   z-index: 500;
 }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants