Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot update mathquill configuration after mount #28

Open
iamdiogo opened this issue Nov 9, 2020 · 4 comments
Open

Cannot update mathquill configuration after mount #28

iamdiogo opened this issue Nov 9, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@iamdiogo
Copy link

iamdiogo commented Nov 9, 2020

I noticed that EditableMathField persists the initial mathquill configuration passed on mount.

There are cases where updating the internal configuration could be required. An example of this is when we're defining custom handlers for the editor.

By persisting the initial configuration, if those handlers require access to state variables, those handlers would be using old versions of those handlers, with the old value of those state variables.

To illustrate this, I made a simple example: https://codesandbox.io/s/react-mathquill-old-config-persistent-8stef

Note:
I understand that it is still possible to manually set the configuration by accessing the mathquill object directly, but this new addition could be great for react-mathquill.


Regarding the implementation of it, I noticed mathquill has a method .config(config) that could be used for updating the configuration.
This method could be used on a per-field basis, so there is no need to re-combine the custom edit handler required by react-mathquill.

@viktorstrate
Copy link
Owner

Hi @iamdiogo, thank you for the detailed issue.

I didn't know that mathquill had the .config(config) method. I think this would be a great addition.
Do you want to take a shot on implementing this?

@viktorstrate viktorstrate added the enhancement New feature or request label Nov 9, 2020
@iamdiogo
Copy link
Author

iamdiogo commented Nov 9, 2020

Hi @iamdiogo, thank you for the detailed issue.

I didn't know that mathquill had the .config(config) method. I think this would be a great addition.
Do you want to take a shot on implementing this?

Yeah, I'll give it a go later this week

@alx-ppv
Copy link
Contributor

alx-ppv commented Jan 28, 2021

I experienced the same issue but with the onMoveOut handler.
I also noticed the issue with the onChange callback with the new version.
You an check here: https://codesandbox.io/s/jovial-sea-wvmfq

Notice that when you change the react-mathquill version to 0.28, it works as expected.

@soegaard
Copy link

@alx-ppv The problem with onChange us gone in racket-mathquill 1.03.
Using your link: https://codesandbox.io/s/jovial-sea-wvmfq
Changing the version number from 1.0.1 to 1.0.3 everything works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants