Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only the first audio poster image is displayed (regression) #253

Open
bgreco opened this issue Aug 29, 2023 · 2 comments · May be fixed by #254
Open

Only the first audio poster image is displayed (regression) #253

bgreco opened this issue Aug 29, 2023 · 2 comments · May be fixed by #254

Comments

@bgreco
Copy link

bgreco commented Aug 29, 2023 •
edited

Description

In a playlist of audio files, only, the first playlist item has its poster image displayed in the videojs player. All following items result in a black player.

Steps to reproduce

  1. Create a playlist using an <audio> tag with with several audio files, each having a poster image.
  2. Play the second playlist item.

Results

Expected

The player should display the second item's poster image.

Actual

No poster image is displayed.

Additional Information

This regression was introduced by #243.

Suggested resolution

Only hide poster images in video playlists. Do not hide poster images in audio playlists.
@bgreco bgreco linked a pull request Aug 29, 2023 that will close this issue
Open
@rochapablo
Copy link

+1

@chipcullen
Copy link

FWIW, I'm seeing the same errant behavior with video playlists as well. Downgrading to 5.0.0 fixed the issue for me.

@Essk Essk mentioned this issue Apr 22, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Always show poster images for audio playlists bgreco/videojs-playlist
3 participants
@chipcullen @bgreco @rochapablo