Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description of the Vote for the Approve function call #1

Open
chrishobcroft opened this issue Apr 5, 2019 · 3 comments
Open

Description of the Vote for the Approve function call #1

chrishobcroft opened this issue Apr 5, 2019 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@chrishobcroft
Copy link

Current behaviour

When using the DAO's Livepeer App to Approve the Livepeer Protocol's Bonding Manager to spend Livepeer Tokens on the DAO's behalf, the current description used is:

Livepeer: Approve the Bonding Manager to spend {# of tokens} tokens from the Livepeer App.

where # of tokens is the number of tokens being approved.

Proposed behaviour

Proposal that the description should read:

Livepeer: Approve the Livepeer Protocol's Bonding Manager {Address of Bonding Manager} to spend {# of tokens} Livepeer Tokens (LPT) from the DAO's Livepeer App. {Address of DAO's Livepeer App}

Screenshots of existing behaviour

Screenshot from 2019-04-05 14-47-36

@willjgriff
Copy link
Member

Unfortunately we can't get access to either the BondingManager address or the LivepeerApp Address for use in this particular string. The string can be updated to that specified without the addresses though.

@chrishobcroft
Copy link
Author

So this would be possible?

Livepeer: Approve the Livepeer Protocol's Bonding Manager to spend {# of tokens} Livepeer Tokens (LPT) from the DAO's Livepeer App.

@willjgriff
Copy link
Member

Yup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants