Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Bump hls version and update the demo #167 #306

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JimLiu
Copy link
Contributor

@JimLiu JimLiu commented Aug 10, 2019

  • Upgrade hls.js to the latest version, the current version does not work for Safari
  • Update the sample code

Relates with
#167

@codecov-io
Copy link

codecov-io commented Aug 10, 2019

Codecov Report

Merging #306 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #306   +/-   ##
=====================================
  Coverage      48%    48%           
=====================================
  Files          47     47           
  Lines        1279   1279           
=====================================
  Hits          614    614           
  Misses        665    665

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea2d2a5...946efc5. Read the comment docs.

@mondaychen
Copy link
Member

@MadeByDouglas does this fix the problem you mentioned?

@mondaychen
Copy link
Member

mondaychen commented Aug 14, 2019

Also -- I noticed that occasionally the HLS example page gives me a typical "un-autoplay-able" problem Uncaught (in promise) DOMException error on video.play() on Chrome. Any idea why?

As I mentioned #215 (comment) I do plan to resolve this kind of issues altogether (hopefully).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants