Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak #57

Open
danh-geo opened this issue Sep 23, 2020 · 0 comments
Open

Memory leak #57

danh-geo opened this issue Sep 23, 2020 · 0 comments

Comments

@danh-geo
Copy link

In Core.swift on line 130 there is self?.removeObserver(observer!) but I believe directly after this you should have:
observer = nil

You do this currently:

self?.removeObserver(observer!)
observer = nil

for lines 136-137 and 172-173 but I think its missing in the above scenario. I notice when I use Xcode Instruments > Leaks that I see memory leaks. Adding the above removes the leaks for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant