Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSMBDS music playback is wrong - too much reverb and square waves are too quiet #389

Open
Alzter opened this issue Oct 5, 2023 · 5 comments
Labels
bug format:nds Issues related to Nintendo DS sequences

Comments

@Alzter
Copy link

Alzter commented Oct 5, 2023

Environment details

  • Operating System+version: Windows 10 Home
  • VGMTrans version: vgmtrans-preview-v1.1-windows_x64
  • Game ROM/music dump name and sha256: New Super Mario Bros. (Europe), I don't know where to find the SHA256

Describe the bug

When attempting to play music from New Super Mario Bros. DS in VGMtrans on the latest version, there is a reverb filter applied over all of the instruments. This differs from how the music sounds on the actual DS hardware and in my opinion it sounds muddier and worse. Also, the square wave instruments are noticeably quieter than they should be.

Steps to reproduce

  1. Open VGMtrans
  2. Open the New Super Mario Bros DS ROM
  3. Attempt to play a music track from the game in VGMtrans

Expected behaviour

The music from New Super Mario Bros, and other DS games by extension, should not have a reverb filter put on all of the instruments, and the square wave channels should have the correct volume.

Additional context

No response

Logs

No response

@Alzter Alzter added the bug label Oct 5, 2023
@sykhro
Copy link
Member

sykhro commented Oct 5, 2023

The reverb part should be fixed in the latest master, which you can download from here. As for the PSG instruments, I'll check that we're outputting them at 0dbfs

@Bonboon229
Copy link

Can confirm the latest nightly does NOT fix the reverb issues at all.

@sykhro
Copy link
Member

sykhro commented Oct 9, 2023

Thanks for testing, will look into it

@sykhro sykhro added the format:nds Issues related to Nintendo DS sequences label Oct 9, 2023
@CodingPigFromTheBushes
Copy link

CodingPigFromTheBushes commented Mar 11, 2024

Kirby Squeak Squad seems to have the same problem with all samples having excessive amounts of reverb. I am on the latest nightly version of VGMTrans.

@Bonboon229
Copy link

Can again confirm this issue, this also affects all Kirby DS Games

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug format:nds Issues related to Nintendo DS sequences
Projects
None yet
Development

No branches or pull requests

4 participants