Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty or incomplete sequences exported for Sonic Rush #385

Open
overcast07 opened this issue Sep 26, 2023 · 0 comments
Open

Empty or incomplete sequences exported for Sonic Rush #385

overcast07 opened this issue Sep 26, 2023 · 0 comments
Labels

Comments

@overcast07
Copy link

overcast07 commented Sep 26, 2023

Environment details

Describe the bug

For some reason, Sonic Rush's music has 12 2sflib files in it. If you import the ROM into VGMTrans, lots of duplicate entries for some sequences (mainly the ones with "Blazy Mix" variants) will show up. The duplicate entries are blank, and usually when exported they will be empty. If you import the ROM and not specifically the 2sflib/mini2sf files, it will be very tedious to find the correct sequence to export, even though you can tell in the app that they're empty by playing them back.

For the "Blazy Mix" tracks and "Raisin' Me Up", in order to export the correct sequence with all the samples intact, you actually have to import the correct mini2sf file, because some of the samples/sequence data(?) are only included inside the mini2sf files.

Ideally, it wouldn't be so complicated to export the sequences correctly. The main pain points are the large amount of duplicate entries and the need (in the aforementioned cases) to specifically import the mini2sf file rather than the 2sflib file. Sonic Rush is the only game I'm aware of that has this issue, but I imagine that some other NDS games might also use a similar setup, and those might also benefit from the issues being fixed.

I first found out about this issue about 2 years ago, and at that time it produced a crash in some cases, but I forgot to write up a bug report for it. When testing today I couldn't reproduce the crash.

Steps to reproduce

  1. Load the Sonic Rush ROM, or one of the "NTR-ASCE-USA_z…" 2sflib files from the game, into VGMTrans
  2. Try to play back and export SEQ_1SONIC, SEQ_1BLAZE, ..., SEQ_7SONIC, SEQ_7BLAZE. There will probably be no audio, and the MIDI file generated will probably be blank.

Expected behaviour

VGMTrans should detect if sequences are actually empty/nonexistent, and should not display them in the list.

VGMTrans should (ideally) be able to figure out if a relevant mini2sf file does or doesn't contain additional sequence data or samples, even if that specific file isn't imported by the user. (In some other cases, such as for New Super Mario Bros., a sequence may match multiple mini2sf files, so the user may have to somehow be able to select, or at least be informed that they can select, which mini2sf file to get the additional data from.)

Additional context

No response

Logs

Click to expand log
[VGMTransQt] Running (1d33f0e, master), BASS 2041100, Qt 5.15.10
[VGMFile] Loaded "NDS PSG samples" successfully.
[VGMFile] Loaded "WAVE_BGM" successfully.
[NDSScanner] Failed to load NDSWaveArch at 0x%08x 
[VGMFile] Loaded "BANK_BGM" successfully.
[NDSScanner] Failed to load NDSInstrSet at 981052
[VGMFile] Loaded "SEQ_1sonic" successfully.
[VGMFile] Loaded "SEQ_1blaze" successfully.
[VGMFile] Loaded "SEQ_2sonic" successfully.
[VGMFile] Loaded "SEQ_2blaze" successfully.
[VGMFile] Loaded "SEQ_3sonic" successfully.
[VGMFile] Loaded "SEQ_3blaze" successfully.
[VGMFile] Loaded "SEQ_4sonic" successfully.
[VGMFile] Loaded "SEQ_4blaze" successfully.
[VGMFile] Loaded "SEQ_5sonic" successfully.
[VGMFile] Loaded "SEQ_5blaze" successfully.
[VGMFile] Loaded "SEQ_6sonic" successfully.
[VGMFile] Loaded "SEQ_6blaze" successfully.
[VGMFile] Loaded "SEQ_7sonic" successfully.
[VGMFile] Loaded "SEQ_7blaze" successfully.
[VGMFile] Loaded "SEQ_boss" successfully.
[VGMFile] Loaded "SEQ_bossW" successfully.
[VGMFile] Loaded "SEQ_boss7" successfully.
[VGMFile] Loaded "SEQ_boss7W" successfully.
[VGMFile] Loaded "SEQ_bossF" successfully.
[VGMFile] Loaded "SEQ_bossFW" successfully.
[VGMFile] Loaded "SEQ_bossE" successfully.
[VGMFile] Loaded "SEQ_bossEW" successfully.
[VGMFile] Loaded "SEQ_muteki" successfully.
[VGMFile] Loaded "SEQ_brethless" successfully.
[VGMFile] Loaded "SEQ_1up" successfully.
@overcast07 overcast07 added the bug label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant