-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Axiom ordering seems may be missing an edge when using a spec definition to satisfy the postcondition on a proof fn in a trait #885
Labels
Comments
utaal
added a commit
that referenced
this issue
Nov 16, 2023
…completeness fix #885, and non-deterministic incompleteness for cases like: ```rust trait T { spec fn a() -> bool; proof fn p() ensures Self::a(); proof fn q() ensures Self::a(); } struct S { pub dummy: nat } impl T for S { spec fn a() -> bool; proof fn p() { Self::q(); } proof fn q() { /* ... */ } } ``` without this change, Self::p was sometimes lowered to AIR without having processed Self::q first, which was not found as a function with a postcondition, which resulted in the encoding for `p()` to be an empty block instead of the expected `(assume <q's postcondition>)`.
utaal
added a commit
that referenced
this issue
Nov 16, 2023
… SCC ordering fix #885, and non-deterministic incompleteness for cases like: ```rust trait T { spec fn a() -> bool; proof fn p() ensures Self::a(); proof fn q() ensures Self::a(); } struct S { pub dummy: nat } impl T for S { spec fn a() -> bool; proof fn p() { Self::q(); } proof fn q() { /* ... */ } } ``` without this change, Self::p was sometimes lowered to AIR without having processed Self::q first, which was not found as a function with a postcondition, which resulted in the encoding for `p()` to be an empty block instead of the expected `(assume <q's postcondition>)`.
utaal
added a commit
that referenced
this issue
Nov 16, 2023
… SCC ordering fix #885, and non-deterministic incompleteness for cases like: ```rust trait T { spec fn a() -> bool; proof fn p() ensures Self::a(); proof fn q() ensures Self::a(); } struct S { pub dummy: nat } impl T for S { spec fn a() -> bool; proof fn p() { Self::q(); } proof fn q() { /* ... */ } } ``` without this change, Self::p was sometimes lowered to AIR without having processed Self::q first, which was not found as a function with a postcondition, which resulted in the encoding for `p()` to be an empty block instead of the expected `(assume <q's postcondition>)`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There's code like this:
that fails to verify, in:
2023-11-03-19-25-29.zip
ordering
zero()
afterzero_spec()
in theimpl KeyTrait for SHTKey
makes it pass.The text was updated successfully, but these errors were encountered: