Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not open jdbc common neither postgres #106

Open
seduardo opened this issue May 17, 2019 · 4 comments
Open

not open jdbc common neither postgres #106

seduardo opened this issue May 17, 2019 · 4 comments

Comments

@seduardo
Copy link

seduardo commented May 17, 2019

Context

when select jdbc client
jdbc common is not add in pom n
and jdbc for mysql or postgres not show in list.

Steps to reproduce

  1. type jdbc in dependences input
  2. generate package
  3. open pom.xml

Extra

  • Anything that can be relevant
@tsegismont
Copy link
Collaborator

@seduardo if you select the vertx-jdbc-client dependency, the generated project will transitively depend on vertx-sql-common, so it's not necessary to explicitly include it.

As for Postgres / MySQL drivers, I need some time to give it some thought, but it doesn't sound like a bad idea.

wdyt @danielpetisme @vietj ?

@danielpetisme
Copy link
Contributor

Sorry for this delayed answer.

IMHO, adding automatically the drivers is a good idea (for the record, we can' distribute Oracle drivers). My main concern is the UX to propose the target database when you have selected vertx-jdbc-client

@tsegismont
Copy link
Collaborator

@seduardo would you like to contribute this?

@seduardo
Copy link
Author

@tsegismont yes I would like. Let me verify the code where I can help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants