Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove read-only flag from compose buffer headlines. #360

Closed
wants to merge 2 commits into from
Closed

Remove read-only flag from compose buffer headlines. #360

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 10, 2019

This partly closes #341. Drawback: The input lines headers can be
edited now.

This partly closes #341. Drawback: The input lines headers can be
edited now.
sx-compose.el Outdated
#("\n" 0 1 (read-only t))
#("Tags : " 0 7 (read-only t intangible t rear-nonsticky t))
#("\n" 0 1 (read-only nil))
#("Tags : " 0 7 (read-only nil intangible t rear-nonsticky t))
Copy link
Owner

@vermiculus vermiculus Apr 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind terribly getting rid of the spurious space here in Tags :? This would also require an update to sx-compose--goto-tag-header.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I wouldn't mind at all.

@vermiculus
Copy link
Owner

Drawback: The input lines headers can be edited now.

That's a pretty serious drawback – I'd like to avoid it if possible. We parse the buffer's content using those headers, so we could get into a state where the question/answer could not be posted and the user wouldn't know why (or worse, we could post with the wrong content!).

I would look at modifying the other properties to see how they behave – possibly reading (elisp) Special Properties and (elisp) Sticky Properties. I'm suspicious of the intangible property given the warnings in the info manual and its noted deprecation.

@ghost
Copy link
Author

ghost commented Apr 11, 2019

I completely agree that the drawback is serious. On the other hand, it's more serious if the component can't be used at all.

That being said: I'm very much an elisp rookie. So more elaborate fixes are beyond my abilities. More or less, I hoped to wake up people who know much more than me to have a look at this very fine package...

I would however be very interested in learning more elisp and this might be a fine opportunity. Could you give me some hints how I could play around with that issue and test/try out my code? Any hints welcome, maybe via PM.

Use cursor-intangible property. Seems to work, but the cursor still
can be set before the first character of a line.
@ghost
Copy link
Author

ghost commented Apr 11, 2019

Improved things somewhat: The keywords are r/o while you can enter text ;)

@matthuszagh
Copy link

Is there any status update on getting this merged? This is a great package and I'd really like to use it but unfortunately the inability to ask questions cuts out a large portion of the use case. Thanks for all the hard work you've already put into this!

@ghost ghost closed this Mar 26, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(sx-ask) funcall-interactively: Text is read-only
2 participants