Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid HTML Markup in sunflower accordion #454

Closed
albig opened this issue Dec 5, 2023 · 0 comments · Fixed by #455
Closed

Invalid HTML Markup in sunflower accordion #454

albig opened this issue Dec 5, 2023 · 0 comments · Fixed by #455
Assignees
@albig
Labels
bug Something isn't working

Comments

@albig
Copy link
Member

albig commented Dec 5, 2023

Check of https://sunflower-theme.de/demo/klappbarer-text/ fails with https://validator.w3.org/

Error: The aria-labelledby attribute must point to an element in the same document.
From line 174, column 250; to line 174, column 331

tton></h4><div class="accordion-collapse collapse sacc942854" aria-labelledby=".sacc942854"><div c

Possible markup solution with aria-labbeldby e.g. in https://www.w3.org/WAI/ARIA/apg/patterns/accordion/examples/accordion/
@albig albig added the bug Something isn't working label Dec 5, 2023
@albig albig self-assigned this Dec 5, 2023
albig added a commit that referenced this issue Dec 6, 2023
@albig
Fix #454 invalid HTML markup in sunflower accordion
408b0e8
@albig albig linked a pull request Dec 6, 2023 that will close this issue
Fix #454 invalid HTML markup in sunflower accordion #455
Merged
@albig albig closed this as completed in #455 Dec 6, 2023
albig added a commit that referenced this issue Dec 6, 2023
@albig
Merge pull request #455 from verdigado/task/fix-accordion
b421c21 
Fix #454 invalid HTML markup in sunflower accordion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@albig albig

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #454 invalid HTML markup in sunflower accordion verdigado/sunflower
1 participant
@albig