-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Messages deleted using "_hidden":true
are not marked as deleted/are not ignored during migration
#34
Comments
_hidden=true
are not marked as deleted/are not ignored during migration"_hidden":true
are not marked as deleted/are not ignored during migration
This will not work as required because Rocket.Chat, when deleting a message, adds |
Rocket.Chat in some cases sets the
"_hidden":true"
property instead of deleting a message from MongoDB, which leads to inclusion of such messages in the mongoexport.The proof of this behavior in the Rocket.Chat server side source code: https://github.com/RocketChat/Rocket.Chat/blob/41b1407804ce17bb54b79cda607554c474246f29/apps/meteor/app/lib/server/functions/deleteMessage.ts#L56
The main point is that we cannot just ignore such messages when migrating, in case the message is the beginning of the thread.
A possible solution is to migrate the message and then delete it, if the
_hidden
flag is set. This will allow us to save threads that started with a deleted message.The text was updated successfully, but these errors were encountered: