Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform is incorect when using background-clip: text #509

Open
uudens opened this issue Jun 11, 2023 · 2 comments · May be fixed by #639
Open

Transform is incorect when using background-clip: text #509

uudens opened this issue Jun 11, 2023 · 2 comments · May be fixed by #639

Comments

@uudens
Copy link

uudens commented Jun 11, 2023

Bug report

Description / Observed Behavior

When using background-clip: text together with transform, the transform is incorrect.
Seems like the problem is that satori applies the transform to both elements (<rect> and <clipPath>) so it causes the transform to be applied twice.

Expected Behavior

Transform should be correct. Setting background-clip: text should not influence the element's transform.

Reproduction

Playground link with reproduction
@mrmianbao
Copy link

mrmianbao commented Jul 2, 2023 •
edited
Loading

I have a similar issue repro link

Looks like that when you provided a clip anything satori wraps that content in a <rect> and sets the clip of that rect to a with the clip src.

Maybe the problem is that the transform is applied to both the <rect> and the <clipPath> resulting in the double transform?

@arguiot
Copy link

arguiot commented Jul 29, 2024

Bump. This still hasn't been fixed, and I agree with @mrmianbao, the transform is applied twice.

@Jackie1210 Jackie1210 linked a pull request Oct 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: background-clip:text should compatible with transform and mask Jackie1210/satori
3 participants
@uudens @arguiot @mrmianbao