parse_cef() bug

[manickamk]

Hello team,

We have identified the bug on parse_cef() function below is the sample log if we remove the space the function is working properly

Please look the below url VRL playground

https://playground.vrl.dev/?state=eyJwcm9ncmFtIjoiLiA9IHBhcnNlX2NlZiEoLm1lc3NhZ2UpIiwiZXZlbnQiOnsibWVzc2FnZSI6IkNFRjowfEluY2Fwc3VsYXxTSUVNaW50ZWdyYXRpb258MXwxfElsbGVnYWwgUmVzb3VyY2UgQWNjZXNzfDN8IGZpbGVJZD0xODQwMDAwMTAwMDQzNzMxNjMgc291cmNlU2VydmljZU5hbWU9YXNzZXRzLnNiLmRhbnNrZXNwaWwuZGsgc2l0ZWlkPTc1MzQ0OTYgc3VpZD0yMDY2NjEyIHJlcXVlc3RDbGllbnRBcHBsaWNhdGlvbj1Nb3ppbGxhLzUuMCAoV2luZG93cyBOVCAxMC4wOyBXaW42NDsgeDY0KSBBcHBsZVdlYktpdC81MzcuMzYgKEtIVE1MLCBsaWtlIEdlY2tvKSBDaHJvbWUvNTkuMC4zMDcxLjExNSBTYWZhcmkvNTM3LjM2IGRldmljZUZhY2lsaXR5PWZyYSBjczI9ZmFsc2UgY3MyTGFiZWw9SmF2YXNjcmlwdCBTdXBwb3J0IGNzMz1mYWxzZSBjczNMYWJlbD1DTyBTdXBwb3J0IGNzMT1OQSBjczFMYWJlbD1DYXAgU3VwcG9ydCBjczQ9YTkzZDVjODktODZiMC00NzdiLTk4OGItYTJlMzhhYmU0N2Y4IGNzNExhYmVsPVZJRCBjczU9OWVjZmFlY2Q1NjM3ODk1YWExMDA2MDRjMWVlZGZmMGY4NDE3NzExYTNmZmI2OGQzZTI0NzdlZDI4MzMxOWNjYmQ0YWU0NzhlNmU5MTI1NjJlNmY1YTllMGNmZGRmMzFiZGE5OGM1NWJmY2Q2YWFlNzExYzBhYTI0YzMwYTFhOTQ4MmE2NGM2YTBkY2MxZTk0NjY4NjI1NDNmYzA4YzQyMDJlZmZmZTA0MmU4MTdjNTMzYmE2YzQ5YmYxNWI4M2M3MTExNDI1NDVjZmRlNzgwYjFjZjQ4MzM4YjJkM2Q3YjA3ODU2YWRhNThkY2E5NWI2YjllN2Q2NWI5OTFjYjE4MiBjczVMYWJlbD1jbGFwcHNpZyBkcHJvYz1Ccm93c2VyIGNzNj1DaHJvbWUgY3M2TGFiZWw9Y2xhcHAgY2NvZGU9QVQgY2ljb2RlPVZpZW5uYSBjczc9NDguMjA0OSBjczdMYWJlbD1sYXRpdHVkZSBjczg9MTYuMzY2MiBjczhMYWJlbD1sb25naXR1ZGUgQ3VzdG9tZXI9RGFuc2tlIFNwaWwgc3RhcnQ9MTcxMjA0MTY2MzUxNiByZXF1ZXN0PWFzc2V0cy5zYi5kYW5za2VzcGlsLmRrL2V0Yy9wcm9maWxlIHJlcXVlc3RNZXRob2Q9R0VUIGFwcD1IVFRQIGFjdD1SRVFfQkxPQ0tFRF9DT09LSUVMRVNTX1NFU1NJT04gZGV2aWNlRXh0ZXJuYWxJZD03MzExMTQyNDUxNDEzMDY1IGNwdD0zODg0NiBzcmM9ODEuMTgxLjU2LjEyMyBlbmQ9MTcxMjA0MTY2MzUxNyBmaWxlVHlwZT0zMDcwNDEgZmlsZVBlcm1pc3Npb249MCBjczk9IGNzOUxhYmVsPVJ1bGUgbmFtZSJ9LCJpc19qc29ubCI6ZmFsc2UsImVycm9yIjpudWxsfQ%3D%3D

Please advise how to fix it ?

[pront]

Hi @manickamk,

The parser assumes there's no ' ' between the | and the key. This could be a good place to start https://github.com/vectordotdev/vrl/blob/main/src/stdlib/parse_cef.rs#L317 if we wanted to relax this constraint and allow spaces after the |.

Are you interested in contributing a PR for this?

[manickamk]

@pront

Thanks for your reply, Yes, I am interested and could you please let me know how to do

[pront]

Thank you @manickamk.

could you please let me know how to do

I would start by adding a test case in this file with the message you shared here. Then you can see if it is possible to relax the parser parts that parse the key/values while ensuring other tests also pass.

[manickamk]

Thank you @pront ,

I will do, please let me know further steps.

Thanks

[manickamk]

Thank you, Once ready, please comment me Thanks Mani

…

On Wed, Apr 3, 2024 at 6:56 PM Pavlos Rontidis ***@***.***> wrote: Thank you @manickamk <https://github.com/manickamk>. could you please let me know how to do I would start by adding a test case in this file <https://github.com/vectordotdev/vrl/blob/main/src/stdlib/parse_cef.rs> with the message you shared here <https://playground.vrl.dev/?state=eyJwcm9ncmFtIjoiLiA9IHBhcnNlX2NlZiEoLm1lc3NhZ2UpIiwiZXZlbnQiOnsibWVzc2FnZSI6IkNFRjowfEluY2Fwc3VsYXxTSUVNaW50ZWdyYXRpb258MXwxfElsbGVnYWwgUmVzb3VyY2UgQWNjZXNzfDN8IGZpbGVJZD0xODQwMDAwMTAwMDQzNzMxNjMgc291cmNlU2VydmljZU5hbWU9YXNzZXRzLnNiLmRhbnNrZXNwaWwuZGsgc2l0ZWlkPTc1MzQ0OTYgc3VpZD0yMDY2NjEyIHJlcXVlc3RDbGllbnRBcHBsaWNhdGlvbj1Nb3ppbGxhLzUuMCAoV2luZG93cyBOVCAxMC4wOyBXaW42NDsgeDY0KSBBcHBsZVdlYktpdC81MzcuMzYgKEtIVE1MLCBsaWtlIEdlY2tvKSBDaHJvbWUvNTkuMC4zMDcxLjExNSBTYWZhcmkvNTM3LjM2IGRldmljZUZhY2lsaXR5PWZyYSBjczI9ZmFsc2UgY3MyTGFiZWw9SmF2YXNjcmlwdCBTdXBwb3J0IGNzMz1mYWxzZSBjczNMYWJlbD1DTyBTdXBwb3J0IGNzMT1OQSBjczFMYWJlbD1DYXAgU3VwcG9ydCBjczQ9YTkzZDVjODktODZiMC00NzdiLTk4OGItYTJlMzhhYmU0N2Y4IGNzNExhYmVsPVZJRCBjczU9OWVjZmFlY2Q1NjM3ODk1YWExMDA2MDRjMWVlZGZmMGY4NDE3NzExYTNmZmI2OGQzZTI0NzdlZDI4MzMxOWNjYmQ0YWU0NzhlNmU5MTI1NjJlNmY1YTllMGNmZGRmMzFiZGE5OGM1NWJmY2Q2YWFlNzExYzBhYTI0YzMwYTFhOTQ4MmE2NGM2YTBkY2MxZTk0NjY4NjI1NDNmYzA4YzQyMDJlZmZmZTA0MmU4MTdjNTMzYmE2YzQ5YmYxNWI4M2M3MTExNDI1NDVjZmRlNzgwYjFjZjQ4MzM4YjJkM2Q3YjA3ODU2YWRhNThkY2E5NWI2YjllN2Q2NWI5OTFjYjE4MiBjczVMYWJlbD1jbGFwcHNpZyBkcHJvYz1Ccm93c2VyIGNzNj1DaHJvbWUgY3M2TGFiZWw9Y2xhcHAgY2NvZGU9QVQgY2ljb2RlPVZpZW5uYSBjczc9NDguMjA0OSBjczdMYWJlbD1sYXRpdHVkZSBjczg9MTYuMzY2MiBjczhMYWJlbD1sb25naXR1ZGUgQ3VzdG9tZXI9RGFuc2tlIFNwaWwgc3RhcnQ9MTcxMjA0MTY2MzUxNiByZXF1ZXN0PWFzc2V0cy5zYi5kYW5za2VzcGlsLmRrL2V0Yy9wcm9maWxlIHJlcXVlc3RNZXRob2Q9R0VUIGFwcD1IVFRQIGFjdD1SRVFfQkxPQ0tFRF9DT09LSUVMRVNTX1NFU1NJT04gZGV2aWNlRXh0ZXJuYWxJZD03MzExMTQyNDUxNDEzMDY1IGNwdD0zODg0NiBzcmM9ODEuMTgxLjU2LjEyMyBlbmQ9MTcxMjA0MTY2MzUxNyBmaWxlVHlwZT0zMDcwNDEgZmlsZVBlcm1pc3Npb249MCBjczk9IGNzOUxhYmVsPVJ1bGUgbmFtZSJ9LCJpc19qc29ubCI6ZmFsc2UsImVycm9yIjpudWxsfQ%3D%3D>. Then you can see if it is possible to relax the parser parts that parse the key/values while ensuring other tests also pass. — Reply to this email directly, view it on GitHub <#781 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE357WMNGJVIH53HL7343FTY3P7QRAVCNFSM6AAAAABFS2GALCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZUGYYTAMZYGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[pront]

Hi @manickamk, this would require a PR to the VRL repo.

[manickamk]

Hi @pront ,
Thank you, could you please update the procedure and steps to do? It will be helpful to me.

[jszwedko]

Hi @pront , Thank you, could you please update the procedure and steps to do? It will be helpful to me.

Hi @manickamk ,

The original request here was if you wanted to contribute the change :) If you do, then the pointers that @pront gave above should be sufficient. If not, no worries, it can wait for someone else to pick it up.

[manickamk]

Hi @jszwedko ,

Yes, I would like to contribute. Could you please provide me with references for setting up a test environment for testing purposes and guidance on how to do it?

Thank you.

[jszwedko]

Hi @manickamk !

Great, please see https://github.com/vectordotdev/vrl/blob/main/CONTRIBUTING.md.

For general Rust setup, you can see https://www.rust-lang.org/learn/get-started