Skip to content
This repository has been archived by the owner on Dec 8, 2020. It is now read-only.

Ability to sanitize headers in the :timber_plug integration #332

Open
binarylogic opened this issue Jan 30, 2019 · 1 comment
Open

Ability to sanitize headers in the :timber_plug integration #332

binarylogic opened this issue Jan 30, 2019 · 1 comment
Assignees

Comments

@binarylogic
Copy link
Contributor

binarylogic commented Jan 30, 2019

As part of splitting out the libraries we need to support the :header_keys_to_sanitize option in the new :timber_plug library. Previously this was defined as a root level timber configuration, but this should be moved to the :timber_plug library instead:

config :timber_plug, header_keys_to_sanitize: ["authorization"]

Note, this should be case insensitive, which I think plug headers are anyway. It's probably best to just move this method into that library:

https://github.com/timberio/timber-elixir/blob/948be10c6416a77b1c27f93a598ae7113a27f80b/lib/timber/utils/http_events.ex#L78

@valpackett
Copy link

Would be nice to be able to completely turn off the inclusion of headers there too.

...also why are they headers_json? what's the purpose of nesting JSON-in-JSON or JSON-in-msgpack?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants