Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Potential bug] Share instance in defaultOps #558

Open
kevindiu opened this issue Jul 8, 2020 · 2 comments
Open

[Potential bug] Share instance in defaultOps #558

kevindiu opened this issue Jul 8, 2020 · 2 comments
Labels

Comments

@kevindiu
Copy link
Contributor

kevindiu commented Jul 8, 2020

Describe the bug:

It have been found the same bug in 2 different package (tls and cache) so just in case I create a bug report for it.
Using defaultOps as var in option.go may create potential bugs in the program as it share the same instance to all callers.

I suggest to change all the implementation of defaultOps to from var to func()? (like this commit)
db434cb

To Reproduce:

Expected behavior:

Environment:

  • Go Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5
@kevindiu kevindiu added type/bug Something isn't working team/core Core team priority/medium labels Jul 8, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label type/bug to this issue, with a confidence of 0.97. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@kpango kpango added size/XXL team/set SET team and removed team/core Core team labels Jul 16, 2020
@kpango
Copy link
Collaborator

kpango commented May 31, 2022

@kevindiu Could you please Investigate this Issue??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants