Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strange Magic Resistance info on Angels #3958

Open
kambala-decapitator opened this issue May 12, 2024 · 8 comments
Open

strange Magic Resistance info on Angels #3958

kambala-decapitator opened this issue May 12, 2024 · 8 comments
Labels

Comments

@kambala-decapitator
Copy link
Collaborator

what's the point of showing "0% resistance"? These angels were an enemy hero unit.

Screenshot 2024-05-12 at 13 41 45

1.5 release

@DjWarmonger
Copy link
Member

Were they standing near Unicorns by any chance?

@kambala-decapitator
Copy link
Collaborator Author

Not 100% sure, but I don't think there were unicorns in the army.

Too bad I didn't make SS of the whole army.

@IvanSavenko
Copy link
Member

Unable to reproduce, without mods at least.
Unicorns have correct bonus descriptions, with correct numbers
Placing unicorns next to other units (e.g. angles) have no effect on bonus descriptions - units under aura don't have it listed in bonuses

@kambala-decapitator
Copy link
Collaborator Author

I don't use any mods.

Could it be an effect of an artifact? Iirc there's one that negates (natural?) resistances

@IvanSavenko
Copy link
Member

Huh, it does looks like Orb of Vulnerability:

"orbOfVulnerability":

It has magic resistance and spell resistance aura bonuses, set to 0

Haven't checked in game, but that's probably it.

@kambala-decapitator
Copy link
Collaborator Author

so, does it make sense to show 0% on creatures that already have 0%? But I don't know if that was really the case, as enemy hero could have an artifact that grants magic resistance.

@DjWarmonger
Copy link
Member

DjWarmonger commented May 13, 2024

For this bonus it doesn't make sense, but many other bonuses are not affected by value (eg. FLYING). So we'll probably need to define "showIfZero" property for every bonus icon, or something similiar.

@kambala-decapitator
Copy link
Collaborator Author

Encountered that hero again: he does have Orb of Vulnerability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants