Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amount of resurrected Vampires doesn't appear in battle log #3957

Open
kambala-decapitator opened this issue May 12, 2024 · 5 comments
Open
Labels
battle Issues involving battles bug

Comments

@kambala-decapitator
Copy link
Collaborator

Should be something like "...and X rise from the dead!"

Screenshot 2024-05-12 at 13 20 15

1.5 release

@kambala-decapitator kambala-decapitator added bug battle Issues involving battles labels May 12, 2024
@MichalZr6
Copy link

MichalZr6 commented May 16, 2024

Hi everyone!
I'm new to OpenSource contributions, but also a great fan of HOMM3.
I think this small issue can be fixed starting with this part of code in BattleActionProcessor.cpp:
obraz

Can someone point me to the file that contains those string literals used in for ex. in the battle log ?
They are obtained from "core.genrltxt" but where is it located ?
obraz

@IvanSavenko
Copy link
Member

Hi. You can look up these strings for example in English translation mod:
https://github.com/vcmi-mods/h3-for-vcmi-englisation/blob/vcmi-1.4/H3forVCMIenglisation/content/config/h3forvcmienglisation/game.json

Alternatively you can export this data using /translate command

@kambala-decapitator
Copy link
Collaborator Author

please never post code as image, paste as text or give a link to specific line inside a file of repository

@MichalZr6
Copy link

After digging into the topic, I think I can come up with a solution :) I built the repo yesterday and might do some tests later today. Side note: Cure also doesn't log info about restored HP.

@kambala-decapitator
Copy link
Collaborator Author

FYI issue about restored hp: #1007

MichalZr6 added a commit to MichalZr6/vcmi that referenced this issue May 24, 2024
Fix issue vcmi#3957: amount of resurrected Vampires doesn't appear in battle log
Fixed plurar / singular text choice - creatures after life drain action
MichalZr6 added a commit to MichalZr6/vcmi that referenced this issue Jun 2, 2024
… battle log

Fixed plurar / singular text choice - creatures after life drain action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
battle Issues involving battles bug
Projects
None yet
Development

No branches or pull requests

3 participants