Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to instructions #60

Open
ndunn219 opened this issue Sep 25, 2020 · 2 comments
Open

Update to instructions #60

ndunn219 opened this issue Sep 25, 2020 · 2 comments

Comments

@ndunn219
Copy link

Just a couple helpful updates to the instructions:

  1. Add pip install autopep8 if you don't have it installed.
  2. run npm i && npm run lint --fix from the frontend directory.
@zessx
Copy link

zessx commented Nov 11, 2020

Plus, the npm commands may fail because we'll run it on our local machine (therefore having various Node versions).
For example, it is failing with Node 15, I had to load Node 10 with nvm to make it work.

I have the feeling these commands should be ran inside a Docker image, but instructions are confusing.

@zessx
Copy link

zessx commented Nov 11, 2020

@vchaptsev Shouldn't it be this instead:

docker-compose up --build
docker-compose run backend autopep8 -r --in-place --aggressive .
docker-compose run frontend npm i && npm run lint --fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants