Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification error with packet sizes that are greater than 65535 #738

Open
xfoukas opened this issue Oct 17, 2024 · 1 comment
Open

Verification error with packet sizes that are greater than 65535 #738

xfoukas opened this issue Oct 17, 2024 · 1 comment

Comments

@xfoukas
Copy link

xfoukas commented Oct 17, 2024

The verifier currently assumes that the max packet size is 65535:

constexpr int MAX_PACKET_SIZE = 0xffff;

As a result, if it is being used in a domain where packet sizes can exceed this value, verification will fail.

Would it make sense to refactor the code, to allow domains to specify the max packet sizes or are there fundamental reasons, as to why the size has to be set to 65535?

@dthaler
Copy link
Contributor

dthaler commented Nov 18, 2024

Looking at the verifier code, I don't see anything special about the number 65535 so I think it would be ok to increase it. IPv6 Jumbograms support payloads up to 2^32-1 (not including the headers).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants