Compatibility with StrictMode #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrpospiech
requested review from
Monteth,
zaxoavoki,
zendranm and
ErnestTeluk
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1324 +/- ##
==========================================
- Coverage 94.55% 94.43% -0.13%
==========================================
Files 231 231
Lines 3823 3827 +4
Branches 1030 1035 +5
==========================================
- Hits 3615 3614 -1
Misses 82 82
- Partials 126 131 +5 ☔ View full report in Codecov by Sentry. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
zendranm
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1194.
Overriding
setStatecaused this issue. I removed it and added checking if the component is mounted before callingsetState.Tested with Vite, React
v18.2.0and Strict Mode.