Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear documentation on custom fields #1132

Open
mariusrak opened this issue Jun 10, 2022 · 1 comment
Open

Unclear documentation on custom fields #1132

mariusrak opened this issue Jun 10, 2022 · 1 comment
Labels
Area: Docs Affects the documentation or reproductions seed
Milestone

Comments

@mariusrak
Copy link
Contributor

Hi,
I'm not sure how to understand CustomAutoField here: https://uniforms.tools/docs/examples-custom-fields/#customautofield

There are mentioned two ways. I understand, that using the AutoField.componentDetectorContext is one of them. But what is second one? is it the deprecated version <AutoForm {...props} autoField={CustomAutoField} />; ?
Because docs says that there are two standard ways, but deprecated way should not be considered standard (I think).

And if the "context" way is preffered one, it could be shown in the example directly.

Thanks for clarification

@Monteth Monteth added this to Needs triage in Open Source (migrated) Jun 24, 2022
@radekmie radekmie self-assigned this Jun 27, 2022
@radekmie radekmie added the Area: Docs Affects the documentation or reproductions seed label Jun 27, 2022
@radekmie radekmie moved this from Needs triage to To do in Open Source (migrated) Jun 27, 2022
@radekmie
Copy link
Contributor

Hi @mariusrak. I do agree, that the deprecated way should not be considered a standard one. We'll update the documentation accordingly.

@radekmie radekmie removed their assignment Nov 4, 2022
@kestarumper kestarumper added this to the v4.0 milestone Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Docs Affects the documentation or reproductions seed
Projects
Status: To do
Development

No branches or pull requests

3 participants