Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scope of the libs within repository domain #141

Open
Stefaneek opened this issue Apr 8, 2020 · 1 comment · May be fixed by #193
Open

Scope of the libs within repository domain #141

Stefaneek opened this issue Apr 8, 2020 · 1 comment · May be fixed by #193
Labels
good first issue Good for newcomers improvement to-do

Comments

@Stefaneek
Copy link
Contributor

Stefaneek commented Apr 8, 2020 •
edited
Loading

Currently, all of the libs have repository scope, we are not sure whether it's a valid approach. We would like to discuss this.
@Sikora00 Sikora00 added the question Further information is requested label Apr 9, 2020
@Sikora00
Copy link
Contributor

It's not. Almost all grouping directories inside the repository domain should have a dedicated scope. Should be improved.

@Sikora00 Sikora00 added improvement to-do and removed question Further information is requested labels Apr 17, 2020
@Sikora00 Sikora00 changed the title Disccuss in team scope of the libs within repository domain Scope of the libs within repository domain Apr 17, 2020
@Sikora00 Sikora00 added the good first issue Good for newcomers label Apr 17, 2020
Damian070 added a commit that referenced this issue Apr 23, 2020
@Damian070
refactor(pmp): scope of the libs within repository domain
7eb0d17 
refs #141
closes #141
Damian070 added a commit that referenced this issue Apr 23, 2020
@Damian070
refactor(pmp): scope of the libs within repository domain
fd0dd34 
refs #141
closes #141
@Damian070 Damian070 linked a pull request Apr 23, 2020 that will close this issue
Open
Damian070 added a commit that referenced this issue Apr 24, 2020
@Damian070
refactor(pmp): scope of the libs within repository domain
6e07abc 
refs #141
closes #141
Damian070 added a commit that referenced this issue Apr 24, 2020
@Damian070
refactor(pmp): scope of the libs within repository domain
42e6dcd 
refs #141
closes #141
Damian070 added a commit that referenced this issue Apr 24, 2020
@Damian070
refactor(pmp): scope of the libs within repository domain
21c9b62 
refs #141
closes #141
Damian070 added a commit that referenced this issue Apr 24, 2020
@Damian070
refactor(pmp): scope of the libs within repository domain
1c1dae3 
refs #141
closes #141
Damian070 added a commit that referenced this issue Apr 24, 2020
@Damian070
refactor(pmp): scope of the libs within repository domain
e75e410 
refs #141
closes #141
Damian070 added a commit that referenced this issue Apr 24, 2020
@Damian070
refactor(pmp): scope of the libs within repository domain
0597955 
refs #141
closes #141
Damian070 added a commit that referenced this issue Apr 24, 2020
@Damian070
refactor(pmp): scope of the libs within repository domain
2288381 
refs #141
closes #141
Damian070 added a commit that referenced this issue Apr 24, 2020
@Damian070
refactor(pmp): scope of the libs within repository domain
16ead75 
refs #141
closes #141
@Damian070 Damian070 mentioned this issue Apr 24, 2020
Closed
Damian070 added a commit that referenced this issue Apr 24, 2020
@Damian070
refactor(pmp): scope of the libs within repository domain
329e78b 
refs #141
closes #141
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers improvement to-do
Projects
None yet
Milestone
No milestone
3 participants
@Stefaneek @Sikora00 @Damian070