Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chain-id should be a property #2211

Open
Adamantios opened this issue Apr 1, 2024 · 0 comments
Open

chain-id should be a property #2211

Adamantios opened this issue Apr 1, 2024 · 0 comments
Labels
core-packages Related to core packages

Comments

@Adamantios
Copy link
Collaborator

The chain-id should be a property in the transaction settlement skill:

https://github.com/valory-xyz/open-autonomy/blob/v0.14.10/packages/valory/skills/transaction_settlement_abci/rounds.py#L248-L250

If the default chain id needs to be used as a fallback, then we can utilize the default chain ID from the params.

The skills that utilize the tx settlement skill should use this property instead of redefining it such as here for example:

https://github.com/valory-xyz/IEKit/blob/v0.9.2/packages/valory/skills/mech_interact_abci/states/base.py#L129-L132

@Adamantios Adamantios added the core-packages Related to core packages label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-packages Related to core packages
Projects
None yet
Development

No branches or pull requests

1 participant