Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skills can't share the same param #1893

Open
dvilelaf opened this issue Mar 22, 2023 · 3 comments
Open

Skills can't share the same param #1893

dvilelaf opened this issue Mar 22, 2023 · 3 comments
Labels
core-packages Related to core packages enhancement New feature or request

Comments

@dvilelaf
Copy link
Collaborator

dvilelaf commented Mar 22, 2023

Subject of the issue

Different skills cannot share the same params because _ensure pops params and therefore the first skill to be loaded is the only one that gets it.

Having the same params in multiple skills makes a lot of sense sometimes. For example, I found this problem while setting the api url for ceramic. Both the ceramic_read and ceramic_write skills use it. The only solution for now is to use kwargs.get() (and miss the type checks) or duplicate the param with different names (which is messy).

@dvilelaf dvilelaf added the bug Something isn't working label Mar 22, 2023
@0xArdi
Copy link
Collaborator

0xArdi commented Mar 22, 2023

Ive faced this issue on multiple occasions.

@Adamantios Adamantios added enhancement New feature or request core-packages Related to core packages and removed bug Something isn't working labels Mar 23, 2023
@8ball030
Copy link
Collaborator

8ball030 commented Aug 3, 2023

Hear hear i too have faced this issue

@Adamantios
Copy link
Collaborator

@angrybayblade did a one-line workaround for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-packages Related to core packages enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants