-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skills can't share the same param #1893
Labels
Comments
Ive faced this issue on multiple occasions. |
Hear hear i too have faced this issue |
@angrybayblade did a one-line workaround for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Subject of the issue
Different skills cannot share the same params because
_ensure
pops params and therefore the first skill to be loaded is the only one that gets it.Having the same params in multiple skills makes a lot of sense sometimes. For example, I found this problem while setting the api url for ceramic. Both the ceramic_read and ceramic_write skills use it. The only solution for now is to use
kwargs.get()
(and miss the type checks) or duplicate the param with different names (which is messy).The text was updated successfully, but these errors were encountered: