Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valkey change proposal (VCP) repository #438

Open
madolson opened this issue May 4, 2024 · 4 comments
Open

Valkey change proposal (VCP) repository #438

madolson opened this issue May 4, 2024 · 4 comments

Comments

@madolson
Copy link
Member

madolson commented May 4, 2024

Redis used to have the RCP (Redis change proposal) project. Right before the license change, we agreed to revive that project and start putting larger initiatives there. For example, https://github.com/valkey-io/valkey/pull/75/files as well as clusterv2 can have their design documents living there.

@valkey-io/contributors does anyone have any concerns with that. And/or, does anyone want to volunteer to create the repository and create some guidelines for using it?

@zuiderkwast
Copy link
Contributor

Sgtm. My only concern is that we'll end up merging something slightly different in the end and that these proposals will become an outdated description of the feature.

At the same time, it looks very close to documentation. Can a proposal like this live as an open PR to the docs repo?

@madolson
Copy link
Member Author

madolson commented May 7, 2024

At the same time, it looks very close to documentation. Can a proposal like this live as an open PR to the docs repo?

The main difference, imo, is that a VCP will be much more technically detailed than most documentation. They will go through the design options, which inform why the decision was made.

@hwware
Copy link
Member

hwware commented May 7, 2024

Is this the correct work flow to work with VCP repo?

  1. One feature proposed here (valkey-io/valkey) ---- Create an issue
  2. Discussion here and approval
  3. Update technical detail in Valkey change proposal (VCP) repository
  4. Create a PR
  5. Merge to unstable branch

Let us confirm it, Thanks

@madolson
Copy link
Member Author

madolson commented May 7, 2024

@hwware I agree with that. Don't start with the VCP, start with the high level proposal first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants