Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Inject slot migration states into RDB #419

Open
PingXie opened this issue May 2, 2024 · 0 comments
Open

[NEW] Inject slot migration states into RDB #419

PingXie opened this issue May 2, 2024 · 0 comments

Comments

@PingXie
Copy link
Member

PingXie commented May 2, 2024

          I know we discussed it, but I forgot the discussion. I still think it's odd that we are putting the replica online before it has the slot information, since it will have a point in time but won't serve any data. It also is getting added to the replication buffer, which could cause replicas to unnecessarily be unable to psync. My previous PoV was why not inject this into the RDB file, which is the true point in time which we are trying to stick on at the end. We already stick "extra" metadata into the RDB file like the psync offset. If a replica comes up, it will also have a partial state.

Originally posted by @madolson in #245 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant