-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map matching: matched_points
are missing in trace_attributes
pbf
response (different set of properties in pbf
and json
)
#4708
Comments
we use pbf for interprocess communication between the various valhalla modules and we actually just convert JSON from the pbf which we already have anyways. however, some stuff never made it into pbf and seems you hit one of the major ones. actually map matching doesn't even have its own pbf section, we re-use the routing stuff here too and add the I think by and large we're fairly consistent with pbf & json, but yeah, some things are lacking and need to be amended. for your particular case would it be enough to have the however, translating the meili results to pbf is a bit bigger.. |
Thank you for the quick response. I made the suggested change is the linked PR. Although it's much less convenient for me, at least it enables my whole use case. |
Hello there,
I am struggling with a issue coming from the fact, that Valhalla
json
andpbf
trace_attributes
responses have very different model.My scenario is the following: I need to compute average speed for all edges returned by
trace_attributes
based on my input points (coordinate+timestamp). So for each segment between two input points I need to break down the route to the corresponding (matched) edges. Additionally, I need to consider edge costs when breaking down.At first, I went the PBF route because of convenience. It gave me edge costs (not seconds):
Unfortunatelly, the second part I need for the computation (
matched_points
) is missing in PBF.I realized that in JSON response, there are
matched_points
, but edge costs are missing.Would be possible to include
matched_points
in the PBF response?Shouldn't be those response formats more consistent/similar to each other? It's just format...
Thank you guys for all the work. It's a great project!
Norek
The text was updated successfully, but these errors were encountered: