-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
almost have mn working #4712
base: master
Are you sure you want to change the base?
almost have mn working #4712
Conversation
the main issue at present is:
|
@@ -21,7 +21,7 @@ | |||
* FIXED: motorcar:conditional should not apply to motorcycle and moped [#4359](https://github.com/valhalla/valhalla/pull/4359) | |||
* FIXED: break shortcuts when there are different restrictions on base edges [#4326](https://github.com/valhalla/valhalla/pull/4326) | |||
* FIXED: Incorrect `edge_index` assignment in `thor_worker_t::build_trace` [#4413](https://github.com/valhalla/valhalla/pull/4413) | |||
* FIXED: lots of issues with CostMatrix (primarily deadend logic) with a complete refactor modeling things very close to bidir A*, also to prepare for a unification of the two [#4372](https://github.com/valhalla/valhalla/pull/4372) | |||
* FIXED: lots of issues with CostMatrix (primarily deadend logic) with a complete refactor modeling things very close to bidir A\*, also to prepare for a unification of the two [#4372](https://github.com/valhalla/valhalla/pull/4372) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one must escape asterisk in markdown
i guess im cursed! seems somehow the macos build has |
I can give it a shot on the M1 I got here |
surprise, osx is giving me a hard time.. sqlite is fussing around, couldnt get a build yet and little nerves right now to deal with brew stuff;) |
i was able to ssh into the mac machine in CI to troubleshoot so no worries there but i just didnt have a ton of time to sink into it yet |
hoping that after some changes this fixes #4688