Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Filters Q/gain control #15

Open
valentijnnieman opened this issue May 8, 2018 · 0 comments
Open

Fix: Filters Q/gain control #15

valentijnnieman opened this issue May 8, 2018 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@valentijnnieman
Copy link
Owner

As it stands the filters are not implemented perfectly. Some filter types use Q, some don't, and the same goes for gain. https://developer.mozilla.org/en-US/docs/Web/API/BiquadFilterNode At this moment we're only allowing Q input, we should allow gain input as well (and, if we really want to do it well, we can disallow Q or gain input for some types i.e. no Q input for low/high shelf filters).

@valentijnnieman valentijnnieman added help wanted Extra attention is needed good first issue Good for newcomers labels May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant