Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task 21,22,23 #1886

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

rajendrayarlagaddausa333
Copy link
Contributor

No description provided.

@vajrang-b
Copy link
Owner

SourceCode/2024/May 2024/Rajendra/Task21/project.json
Main.xaml
Log Message not used in workflow Main.
This is an important point! Log messages help you and others understand the flow of your process, which makes maintenance and debugging much easier.

Variables

  • temp_ data: Does not respect set pattern ^((dt_)?(A- Z|a-z)+(0-9)$|out_A-Za-zA-Za-z0-9$. Make sure all variables follow this naming convention.
  • temp_data: Should start with a dt_ prefix, as per the set pattern. DataTable Variable should always have a dt_ prefix.
  • temp_index and temp_result: Same issue as temp_data - they don't respect the set pattern.

For Each Row in Data Table
The activity has a default name. Try to add a more descriptive title to make it clearer what this activity is doing.

Score: 4/5

Please note that I didn't provide any code suggestions for review, and I kept my responses simple and easy to understand.

@vajrang-b
Copy link
Owner

SourceCode/2024/May 2024/Rajendra/Task22/project.json
Main.xaml

  • The Write Line activities should be removed as they can be replaced with tracepoints during debug.
    Consider changing them to Log Message if really needed for debugging purposes.
  • Using Log Message activities is important both during development and after release.

Variables

  • VB_Data does not have the DataTable prefix. It should start with "dt_".
  • VB_Data and DT_Result do not follow the naming convention. They should be renamed according to the set pattern: ^(dt_)?(A-Z|a-z)+(0-9)*$|_out_[A-Za-z0-9]*$.
  • Result_output does not follow the naming convention. It should be renamed according to the set pattern: ^(dt_)?(A-Z|a-z)+(0-9)*$|_out_[A-Za-z0-9]*$.

Activities

  • Build Data Table and For Each Row in Data Table activities have default names. They could be easier to understand with more descriptive titles.
  • The Write Line activity has a default name. It could be renamed for better understanding.

Score: 4/5

(Note: I did not provide code suggestions or individual scores, as per your request.)

@vajrang-b
Copy link
Owner

SourceCode/2024/May 2024/Rajendra/Task23/project.json
Main.xaml
Log Message not used in workflow Main.
Using Log Message activities is important both during development and after release. They help understanding the flow path which is very useful for maintenance and, when an error occurs, to easily identify the source and the cause.

Variable DT_Man does not respect the set pattern ^((dt_)?)((A-Z|a-z)+(0-9))$|(out[A-Za-z]+[0-9]$)
Make sure all the variables follow the naming convention.

Score: 5/5

Please note that unused dependencies and logs should be reviewed for removal or modification to improve process execution time.

@krish952-creator
Copy link
Collaborator

@rajendrayarlagaddausa333
Task – 21
Code verified.
Task – 22
Code verified.
Task – 23
Code verified.

@krish952-creator krish952-creator merged commit dbf0e5f into vajrang-b:main May 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants