Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ham] アウトラインにラベルが二重で表示される #11

Open
vain0x opened this issue Jan 24, 2024 · 2 comments
Open

[ham] アウトラインにラベルが二重で表示される #11

vain0x opened this issue Jan 24, 2024 · 2 comments
Labels
area:ham hsp3-analyzer-mini bug Something isn't working

Comments

@vain0x
Copy link
Owner

vain0x commented Jan 24, 2024

VSCodeの「アウトライン」パネルに単一のラベルが2つずつ表示されてしまいます

参考: VSCodeでHSP3開発を超快適にしよう！ [2023年] #VSCode - Qiita > #アウトライン
@vain0x vain0x added bug Something isn't working area:ham hsp3-analyzer-mini labels Jan 24, 2024
vain0x added a commit that referenced this issue Jan 25, 2024
@vain0x
fix(ham): ラベルのシンボルが重複する問題を修正 (refs #11)
2f6c016 
原因:

- ラベルの定義がプリプロセス時と意味解析時に2回登録されていたため

影響:

- アウトラインにラベルが重複して表示されていた
    (document_symbolの結果に重複して含まれていたため)
- ラベル間のシンボル間参照も一部、おかしくなっていた
@vain0x
Copy link
Owner Author

vain0x commented Jan 25, 2024

v0.5.0 で修正しました

@vain0x vain0x closed this as completed Jan 25, 2024
vain0x added a commit that referenced this issue Jan 30, 2024
@vain0x
Revert "fix(ham): ラベルのシンボルが重複する問題を修正 (refs #11)"
925242d 
This reverts commit 2f6c016.
@vain0x
Copy link
Owner Author

vain0x commented Jan 30, 2024

ほかの問題があったため、v0.5.1 で元に戻しました (#12 参照)

@vain0x vain0x reopened this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:ham hsp3-analyzer-mini bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vain0x