Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace yoga-layout-prebuilt with yoga-wasm-web #550

Merged
merged 5 commits into from Mar 17, 2023

Conversation

amitdahan
Copy link
Contributor

@amitdahan amitdahan commented Mar 1, 2023

Summary

This is an attempt at tackling #150 by replacing yoga-layout-prebuilt with yoga-wasm-web.

(FWIW, relies on the recent #546 for top-level await)

@amitdahan amitdahan marked this pull request as ready for review March 1, 2023 10:15
src/styles.ts Outdated Show resolved Hide resolved
src/yoga.ts Outdated Show resolved Hide resolved
@amitdahan
Copy link
Contributor Author

Had to manually ignore n/file-extension-in-import for the yoga-wasm-web/auto imports.

Seems related to this issue: mysticatea/eslint-plugin-node#258

@vadimdemedes
Copy link
Owner

Thanks @amitdahan, great work!

@vadimdemedes vadimdemedes merged commit c97a2ee into vadimdemedes:master Mar 17, 2023
3 checks passed
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants