WIP Adds support for poseidon2 multihashes #974
Draft
+120
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dryajov
force-pushed
the
multihash-poseidon2
branch
from
2d30145 to
c00b9b7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #974 +/- ##
============================================
+ Coverage 83.14% 83.37% +0.23%
============================================
Files 91 91
Lines 15335 15347 +12
============================================
+ Hits 12750 12796 +46
+ Misses 2585 2551 -34
|
Fixes assembly incompatibility with secp256k1: mratsim/constantine#309
dryajov
force-pushed
the
multihash-poseidon2
branch
from
4f2259e to
b239791
Compare
# Conflicts: # libp2p.nimble # libp2p/cid.nim # libp2p/multicodec.nim # libp2p/multihash.nim # tests/testmultihash.nim
|
Fix of constantin required. -> Looking into it now. |
AlejandroCabeza
force-pushed
the
multihash-poseidon2
branch
2 times, most recently
from
5ebe275 to
036e110
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably going to be work in progress for a while...