Mitmproxy script not compatible with mitmproxy 6

[ghost]

with mitmproxy 6.0.2 on Ubuntu (kali2), python 2.7.18, I get an error in mitmproxy_oracleforms.py at line 145:

Addon` error: Traceback (most recent call last):
  File "mitmproxy_oracleforms.py", line 145, in response
    flow.response.replace("Mate", "Matf")
AttributeError: 'Response' object has no attribute 'replace'

It works with this
flow.response.content = flow.response.content.replace(b"Mate", b"Matf")
instead.

[v-p-b]

mitmproxy probably changed its API somewhere between 4 and 6. The version requiremend is already documented here:

https://github.com/v-p-b/oracle_forms#mitmproxy-support

Do you think it's possible to upgrade the script to maintain compatibility for both 4 and 6?

[ghost]

I have no idea, it's the first time I used mitmproxy at all and my python is read-only, so I'm the wrong person to ask. But I guess almost everybody will use v5 oder v6 anyway. And v4 even has a big "insecure" tag here: https://pyup.io/changelogs/mitmproxy/

[v-p-b]

You can set up virtualenv for Python, then use pip to install the version required by the script. Regarding the bugs: this is a testing tool, that you should use against trusted applications:

https://docs.python.org/3/tutorial/venv.html

I keep this open as a TODO item, to keep up with mitmproxy, but restrict commenting to keep the discussion focused. Feel free to ask any questions in separate issues with descriptive titles! (seriously people, this is not Instagram!)