-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexpected argument order when decompiling program #1338
Labels
bug
This issue describes a defect in Reko
Comments
uxmal
added a commit
that referenced
this issue
Apr 19, 2024
Start of implementation of parameter ordering respecting the ABI of the Platform. Create AbstractCallingConvention implementation base class.
uxmal
added a commit
that referenced
this issue
Apr 30, 2024
Completed core implementation of parameter ordering respecting the ABI of the Platform. Individual ABIs need to be adjusted individually. Created AbstractCallingConvention implementation base class. Added CallingConventionMatcher class, which tries to find a calling convention that matches the parameters by a Procedure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
(See #1337 opened by @yangzao for the binary in question,
program1
)Original code:
Decompiled code:
The argument order of set_var() is recovered incorrectly.
The order of
qwLoc18_141
(corresponds tol_l
) anddwLoc0C_144
(corresponds toi_l
) gets reversed.The text was updated successfully, but these errors were encountered: