-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BigInt check in Arrow profiler is breaking Svelte-kit / Vite builds #263
Comments
I am seeing this as well. |
Sorry that this is causing issues. Is the crux of the issue the use of the |
HI. As you can read above from the 8 Feb, I have located the exact problem for you. In my local copy of the library, I remove this check and everything compiles fine. If you don't need it for the library , then perhaps try to safely remove the below, I think? else if (p.bigints === valid) {
const v = -p.min > p.max ? -p.min - 1n : p.max;
return p.min < 0
? v < 2 ** 63 ? Type.Int64
: error(`BigInt exceeds 64 bits: ${v}`)
: p.max < 2 ** 64 ? Type.Uint64
: error(`BigInt exceeds 64 bits: ${p.max}`);
} |
The one that causes problems is on line 104 https://github.com/uwdata/arquero/blob/master/src/arrow/encode/profiler.js
Changing target on Vite to es2020 isn't really viable for my project at least, and is difficult to do inside a svelt-kit config.
Is that BigInt support really necessary?
The text was updated successfully, but these errors were encountered: